fix(SummaryStatistics): fix in sanity_filter #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@project-defiant could you please have a look on it? for some reason, it dosen't work in my hands and fails "make test" |
|
@addramir it should be ready to run |
|
@project-defiant I made small changes in sanity filter function and test. Please have a look. If you agree - you can approve it. |
| None, | ||
| 0.4671, | ||
| ), | ||
| ] | ||
| input_df = spark.createDataFrame(data=data, schema=SummaryStatistics.get_schema()) | ||
| input_df.printSchema() |
There was a problem hiding this comment.
I missed this one, good catch
project-defiant
approved these changes
May 30, 2024
|
@addramir all good for merge |
project-defiant
added a commit
that referenced
this pull request
Jun 14, 2024
* fix(SummaryStatistics): fix in sanity_filter * fix: adding prune of inf values * fix(dataset): removal of inf values from beta and stderr * fix: fix in test and sanity filter --------- Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk> Co-authored-by: Szymon Szyszkowski <69353402+project-defiant@users.noreply.github.com>
project-defiant
pushed a commit
that referenced
this pull request
Jul 12, 2024
This reverts commit cf0d7b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
This PR adds filtering by inf in summary statistics.
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
devbranch?make test)?poetry run pre-commit run --all-files)?