Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ld): correct syntax for the get_numpy_matrix static method #624

Merged
merged 1 commit into from
May 29, 2024

Conversation

tskir
Copy link
Contributor

@tskir tskir commented May 29, 2024

✨ Context

Finemapping relies on the ld module to perform some operations. This module has an error in its static method, get_numpy_matrix.

🛠 What does this PR implement

This is a simple fix to ensure the static method works. Note that this is not the most elegant possible solution; it is possible that a static method could be replaced with a better approach, but this is outside the scope of this simple fix PR.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@tskir tskir self-assigned this May 29, 2024
@github-actions github-actions bot added bug Something isn't working Datasource size-XS labels May 29, 2024
@addramir addramir merged commit f0960b1 into dev May 29, 2024
4 checks passed
@addramir addramir deleted the tskir-susie-fix branch May 29, 2024 12:45
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Datasource size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants