fix(ld): correct syntax for the get_numpy_matrix
static method
#624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
Finemapping relies on the
ld
module to perform some operations. This module has an error in its static method,get_numpy_matrix
.🛠 What does this PR implement
This is a simple fix to ensure the static method works. Note that this is not the most elegant possible solution; it is possible that a static method could be replaced with a better approach, but this is outside the scope of this simple fix PR.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?