Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(susie_finemapper): fix in the fine-mapper in case of sum stat imputation is False #627

Merged
merged 2 commits into from
May 29, 2024
Merged

fix(susie_finemapper): fix in the fine-mapper in case of sum stat imputation is False #627

merged 2 commits into from
May 29, 2024

Conversation

addramir
Copy link
Contributor

@addramir addramir commented May 29, 2024 •
edited
Loading

✨ Context

Fix in the fine-mapper in case of sum stat imputation is False.
It doesn't load the whole matrix.

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@addramir addramir requested a review from tskir May 29, 2024 16:11
@github-actions github-actions bot added bug Something isn't working size-S Step labels May 29, 2024
@addramir addramir marked this pull request as ready for review May 29, 2024 16:12
tskir
tskir approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@tskir tskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks sensible to me, let's see if it helps us with the runs!

@tskir tskir merged commit 48cf2a8 into dev May 29, 2024
4 checks passed
@tskir tskir deleted the yt_susie_fmer_fix branch May 29, 2024 20:32
project-defiant pushed a commit that referenced this pull request Jun 14, 2024
@addramir @project-defiant
fix(susie_finemapper): fix in the fine-mapper in case of sum stat imp…
79e0ee2 
…utation is False (#627)

* fix(susie_finemapper): fix in the FMer in case ss_imp=False

* fix: small fix in docs
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Revert "fix(susie_finemapper): fix in the fine-mapper in case of sum …
0f31ad0 
…stat imputation is False (#627)"

This reverts commit 79e0ee2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskir tskir tskir approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size-S Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addramir @tskir