Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable interface with gcp secrets manager #635

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

ireneisdoomed
Copy link
Contributor

@ireneisdoomed ireneisdoomed commented Jun 7, 2024

✨ Context

I needed a way to manage secrets project wise so that the W&B API key is automatically available when running the pipeline. The Secrets Manager API provides exactly this.
Service accounts that we use for our dev development and the one used by Airflow have been granted access to this API.

🛠 What does this PR implement

access_gcp_secret is an interface to request secrets from https://console.cloud.google.com/security/secret-manager?authuser=1&project=open-targets-genetics-dev

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@project-defiant project-defiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ireneisdoomed ireneisdoomed merged commit ca43fff into dev Jun 11, 2024
4 checks passed
@ireneisdoomed ireneisdoomed deleted the il-fetch-secret branch June 11, 2024 11:33
project-defiant pushed a commit that referenced this pull request Jun 14, 2024
* feat: enable interface with gcp secrets manager

* chore: add google-cloud-secret-manager

* chore: merge
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants