Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: credible set quality filtering #640

Merged
merged 4 commits into from
Jun 11, 2024
Merged

feat: credible set quality filtering #640

merged 4 commits into from
Jun 11, 2024

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Jun 11, 2024

✨ Context

This PR adds a static method for doing P-value/purity filtering, as well as annotating the locus and then performing LD-based clumping to keep only the most significant studyLocus where multiple are in high LD.

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@Daniel-Considine Daniel-Considine merged commit 45d991c into dev Jun 11, 2024
4 checks passed
@Daniel-Considine Daniel-Considine deleted the dc-credset-qc branch June 11, 2024 14:06
project-defiant pushed a commit that referenced this pull request Jun 14, 2024
* feat: credible set quality filtering

* fix: purity threshold
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants