-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: platform pis stage first prototype #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-defiant
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, just for clarification.
I'm organizing the code a bit more, I'll commit it ASAP. |
@project-defiant just pushed those changes, you can take a look! 👍 |
project-defiant
approved these changes
Jul 18, 2024
@javfg you can merge when ready, nicely done! |
javfg
added a commit
that referenced
this pull request
Sep 3, 2024
javfg
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: platform pis stage first prototype (#11) * fix: remove duplicate operator * fix: simplify pis dag * fix: use correct service account * style: ignore init methods for docs * fix: ensure error logs even if run fails * fix: add jinja filter to common kwargs * fix: fetch more logs per request * fix: increase ram for pis * feat: load configuration from orchestrator * fix: add timeout * feat: gce dockerized workload operator * fix: empty log pager bug and old timestamps for exit code * feat: wip conditional run for pis steps * fix: export some more stuff from utils * chore: add some exclusions to pydocstyle * fix: remove interrogate and pydoclint * feat: conditional run for pis steps * fix: do not add merge tags to docker compose * fix: apply suggestions from code review Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk> * fix: drop poetry lock hook --------- Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first version of the PIS DAG for the Platform Pipeline, using Cloud Run jobs.
Things missing:
otar
step)