Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eqtl_catalogue): params and documentation update #41

Merged
merged 3 commits into from
Oct 17, 2024
Merged

chore(eqtl_catalogue): params and documentation update #41

merged 3 commits into from
Oct 17, 2024

Conversation

project-defiant
Copy link
Collaborator

Context

  • Refactoring of eqtl_catalogue_ingestion dag configuration
  • Added documentation of eqtl_catalogue_data bucket

@project-defiant project-defiant marked this pull request as ready for review October 15, 2024 08:01
@project-defiant project-defiant requested review from d0choa and DSuveges and removed request for d0choa October 15, 2024 12:14
@project-defiant project-defiant changed the title refactor(eqtl_catalogue): adding documentation and adjusting config chore(eqtl_catalogue): params and documentation update Oct 16, 2024
@project-defiant
Copy link
Collaborator Author

@DSuveges I have resolved the conflicts

d0choa
d0choa approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does this work as-is? Since we have to run it, it would be good to see if somebody else can run it

@d0choa d0choa merged commit a439073 into dev Oct 17, 2024
2 checks passed
@d0choa d0choa deleted the eqtl-catalogue-refactoring branch October 17, 2024 09:40
@project-defiant project-defiant mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0choa d0choa d0choa approved these changes

@DSuveges DSuveges Awaiting requested review from DSuveges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@project-defiant @d0choa