Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consistent navigate button #553

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

d0choa
Copy link
Contributor

@d0choa d0choa commented Nov 22, 2024

This PR just standardises the navigate column icon. It can be changed later on but at least they are consistent now.

Two questions I might not be the best person to answer:

  • Is there enough here to do an abstraction that is reused?
  • There could be a problem with alignment. Content was centered and header untouched. It looked good in busy widgets but not to busy. Alignment is not totally consistent in this PR

@d0choa
Copy link
Contributor Author

d0choa commented Nov 22, 2024

Examples of the 2 different implementations:
Study page:
Screenshot 2024-11-22 at 21 15 47
Variant page
Screenshot 2024-11-22 at 21 15 09

@carcruz
Copy link
Contributor

carcruz commented Nov 22, 2024

I'll merge to keep the UI consistent.
I agree with the feedback. We can either extend our Link component or create a new one for this purpose, which will address the inconsistent styles.

@carcruz carcruz merged commit c859339 into main Nov 22, 2024
11 checks passed
@carcruz carcruz deleted the do_consistent_navigate_buttton branch November 22, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants