feat(core): add otelto opentdf services #1858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strantalis
reviewed
Jan 16, 2025
Comment on lines
196
to
200
| if as.Tracer != nil { | ||
| var span trace.Span | ||
| ctx, span = as.Tracer.Start(ctx, "GetDecisions") | ||
| defer span.End() | ||
| } |
There was a problem hiding this comment.
I am thinking we might want to create some type of metrics / tracing package that we could use to abstract away a lot of these if as.Tracer != nil checks
There was a problem hiding this comment.
we already have a tracing package so we can probably add it there.
dmihalcik-virtru
requested changes
Jan 30, 2025
| "gopkg.in/natefinch/lumberjack.v2" | ||
| ) | ||
|
|
||
| const ServiceName = "github.com/opentdf/platform/service" | ||
| const ServiceName = "opentdf-service" |
There was a problem hiding this comment.
Is there a naming convention we are following here?
dmihalcik-virtru
previously approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Testing Instructions