feat(sdk): EC-wrapped unit tests #1924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lets KAS use an elliptic key based mechanism for key (split) encapsulation
dmihalcik-virtru
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
One optional suggestion to improve output/selection in IDEs that support table tests
|
|
||
| for _, config := range testConfigs { | ||
| inBuf := bytes.NewBufferString(plainText) |
There was a problem hiding this comment.
Better style here is to name these and make them explicit subtests, e.g. using s.Run()
https://pkg.go.dev/github.com/stretchr/testify@v1.10.0/suite#Suite.Run
pflynn-virtru
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
*Updated FakeKas to support ec-wrapped
Checklist
Testing Instructions