Skip to content

fix(sdk): Allow tdfs with explicit 4.2.2 specver #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Apr 8, 2025

Proposed Changes

  • javascript sdk sets this in compatiblity mode

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners April 8, 2025 18:52
@elizabethhealy
Copy link
Member

this is fine to add but sdks released between 3.26 and now won't be able to decrypt something with schema 4.22 and hex, if a schema version is present it will assume its hexless
javascript should not add a schema version if target < 4.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants