Added retry on chunk download on any error #179

danielRicaud · 2023-04-26T19:53:31Z

No description provided.

github-actions · 2023-04-26T19:55:02Z

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Signed-off-by: Daniel Ricaud <dricaud@virtru.com>

dmihalcik-virtru · 2023-04-28T19:23:41Z

lib/tdf3/src/utils/chunkers.ts

+axiosRetry(axios, {
+  retries: 3,
+  retryDelay: axiosRetry.exponentialDelay,
+  retryCondition: () => true,


We probably don't want to retry on every failure. Do you know what the default condition is?

Also, does this affect all global axios requests? We might want to start using axios.create to allow more fine-grained control - and avoid accidentally altering behavior outside of what we intend

Also it looks like you can set these parameters on a given request (at least, if paired with axios.create, although IDK if that is required or just in the example code), so we maybe want to be more selective about this specific change

Previously it'd only retry indempodent requests and now it also included POST/PATCH along with the indempodent methods. It also now retries timeout related errors like ECONNABORTED that would previously not be retried.