✨ @opentdf/remote-store library #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
force-pushed
the
feature/remote-store-lib
branch
2 times, most recently
from
99c42fb to
ee05968
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dmihalcik-virtru
force-pushed
the
feature/remote-store-lib
branch
2 times, most recently
from
071fda3 to
d153f9e
Compare
dmihalcik-virtru
force-pushed
the
feature/remote-store-lib
branch
from
d153f9e to
d380355
Compare
- Creates new library, @opentdf/remote-store, to contain the to/from AWS code. - Removes @aws-sdk/* deps from @opentdf/client - NO TESTS YET apparently these didn't have any tests anyway? I'll write up a ticket to create them
dmihalcik-virtru
force-pushed
the
feature/remote-store-lib
branch
from
d380355 to
ffcb821
Compare
dmihalcik-virtru
changed the title
|
bump the version, major version? |
|
after the version bump, we'll need to update https://github.com/opentdf/opentdf/tree/main/examples/secure-remote-storage |
pflynn-virtru
previously approved these changes
Aug 18, 2023
it is easier to keep these all the same version for now
|
I've tested it locally with the secure-remote-storage sample |
|
See relevant draft PR: https://github.com/opentdf/opentdf/pull/256 |
danielRicaud
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.