Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix a ReferenceError in node #76

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Aug 18, 2022

When loading the generated cjs in node contexts, the relevant code generates a value error on dereference. Checking for undefined explicitly should prevent this behavior.

Copy link
Contributor

@cassandrabailey293 cassandrabailey293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit 43e69e8 into opentdf:main Aug 27, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/undef-check branch August 27, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants