fix: logging weights correctly in utils/weight_utils.py#2362
Merged
thewhaleking merged 10 commits intoopentensor:stagingfrom Nov 6, 2024
Merged
fix: logging weights correctly in utils/weight_utils.py#2362thewhaleking merged 10 commits intoopentensor:stagingfrom
thewhaleking merged 10 commits intoopentensor:stagingfrom
Conversation
Contributor
|
Please update this to merge into staging. |
basfroman
requested changes
Oct 17, 2024
basfroman
requested changes
Oct 17, 2024
grantdfoster
force-pushed
the
fix--logging-weights-correctly
branch
from
7f17b20 to
89860e9
Compare
basfroman
approved these changes
Oct 17, 2024
grantdfoster
force-pushed
the
fix--logging-weights-correctly
branch
from
191574f to
05eaf8a
Compare
thewhaleking
approved these changes
Oct 18, 2024
basfroman
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#2361
Description of the Change
Any instances where weights are being logged have been changed to
bt.logging.debug("weights", *weights). The bug occurs when we attempt to log withbt.logging.debug("weights", weights)Alternate Designs
The only other alternative was deleting the logging lines - I chose to keep them, but simply log them correctly.
Possible Drawbacks
None.
Verification Process
I have run my validator on our testnet, starting from a completely fresh state file. This means that I saw the validator correctly set weights when there were NO weights to set (i.e. all 1's), and when there WERE weights to set (i.e. miners have done some work and have been scored).
Release Notes
Fixes logging bug where weights were being logged w/o an
*