feat: Add logging for unexpected header keys in Synapse #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basfroman
previously approved these changes
Jan 21, 2025
thewhaleking
previously approved these changes
Jan 21, 2025
thewhaleking
dismissed stale reviews from basfroman and themself
The base branch was changed.
thewhaleking
approved these changes
Jan 21, 2025
thewhaleking
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds proper logging for unexpected header keys in the Synapse.parse_headers_to_inputs method. Previously, these keys were silently ignored with a TODO comment. Now, when an unexpected header key is encountered, it will be logged as a warning message, which will help with debugging and monitoring of the system.
Changes made:
This change helps developers better understand what unexpected data is being received in the headers during runtime.