perf: don't use 2 threads to create FastAPI server #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyzniewski-reef
requested review from
basfroman,
camfairchild,
ibraheem-abe and
thewhaleking
thewhaleking
requested changes
Jan 21, 2025
zyzniewski-reef
force-pushed
the
perf/creating_fastapi_server
branch
2 times, most recently
from
4727724 to
bc49250
Compare
zyzniewski-reef
force-pushed
the
perf/creating_fastapi_server
branch
from
bc49250 to
733895c
Compare
thewhaleking
approved these changes
Jan 21, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
This is a great catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Looks like
FastAPIThreadedServer.startis launching 2 threads to start FastAPI/uvicorn server with no real reason.Quantitative Performance Benefits
No performance tests were run - it's a simple design change.
Possible Drawbacks
None?
Verification Process
Created unittest. Ran Axon and checked FastAPI is listening in accepting requests.
Release Notes