Skip to content

Conversation

@Marcofann
Copy link
Contributor

@Marcofann Marcofann commented Jan 31, 2025

  • Fixed "commited""committed" in async_commit_reveal.py and commit_reveal.py.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Risks

Low – changes are minor typo fixes and do not affect functionality.

@thewhaleking thewhaleking self-requested a review January 31, 2025 15:27
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Marcofann, thanks for the PR. There's some issues however.

  1. PRs should be based off staging.
  2. arange is an array range, a function of NumPy. It is very different than arrange, which means to order something.

Please remove the NumPy stuff, and base your PR off staging.

@Marcofann Marcofann changed the base branch from master to staging February 1, 2025 12:51
@Marcofann
Copy link
Contributor Author

@thewhaleking Hi!

I've made the requested changes:

  1. The base branch is now staging.
  2. Removed the np.arange() change as requested.

Please let me know if anything else needs to be updated.

@thewhaleking thewhaleking requested a review from a team February 3, 2025 14:05
@thewhaleking thewhaleking merged commit 9919f6a into opentensor:staging Feb 4, 2025
15 checks passed
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants