Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds improvements and minor fixes #112

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Adds improvements and minor fixes #112

merged 4 commits into from
Sep 24, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

  • Adds --netuid alias to --netuids used in wallet inspect + overview
  • Enhances UI of set config -> Now we display current configs + selection is through numbers
  • Prompts for wallet name beforehand in create-hotkey
  • Changes default input in stake_add and stake_remove to hotkey instead of ss58
  • Updates sudo_set to display 1-1 numbering w.r.t current hyperparams table
  • Updates help texts
  • Fixes netuid filtering in overview, inspect
  • Orders root list with largest stake
  • Adds back account column in stake show
  • Table readability enhancements

thewhaleking
thewhaleking requested changes Sep 24, 2024
View reviewed changes
bittensor_cli/cli.py Outdated Show resolved Hide resolved
thewhaleking
thewhaleking previously approved these changes Sep 24, 2024
View reviewed changes
rajkaramchedu
rajkaramchedu previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@rajkaramchedu rajkaramchedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

bittensor_cli/src/commands/root.py Outdated Show resolved Hide resolved
bittensor_cli/src/commands/root.py Show resolved Hide resolved
bittensor_cli/src/commands/root.py Outdated Show resolved Hide resolved
bittensor_cli/src/commands/root.py Show resolved Hide resolved
bittensor_cli/src/commands/root.py Outdated Show resolved Hide resolved
@ibraheem-opentensor ibraheem-opentensor merged commit 6a8dd57 into main Sep 24, 2024
3 checks passed
@ibraheem-opentensor ibraheem-opentensor deleted the enhancements/feedback-fixes branch September 25, 2024 00:52
@ibraheem-opentensor ibraheem-opentensor mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkaramchedu rajkaramchedu rajkaramchedu approved these changes

@thewhaleking thewhaleking Awaiting requested review from thewhaleking

@garrett-opentensor garrett-opentensor Awaiting requested review from garrett-opentensor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibraheem-opentensor @rajkaramchedu @thewhaleking