Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update help text in the BTCLI #139

Merged
merged 4 commits into from
Oct 1, 2024
Merged

update help text in the BTCLI #139

merged 4 commits into from
Oct 1, 2024

Conversation

dougsillars
Copy link
Contributor

I fixed 3 sections:

  1. setting weighst is done by root validators - not senators (all senators are root valis, but not all root valis are senators)
  2. registering to root was using the same text as neuron registrtaion for the other subnets. Made this more root specific.
  3. removed the wallet name example. this resolves btcli root list-delegates help: implies the ability to filter by wallet, yet not an option #138

@dougsillars
root register message
783b704
@dougsillars
set-weights help message
1caa7f5 
valis on root set weights.. not just senators.
@dougsillars
remove --wallet-name form list delegates examples
54233cb 
I think this is covered in my-delegates, and the help text was not removed from llist-delegates
@dougsillars
fix spelling on change
f440bd6
@thewhaleking thewhaleking mentioned this pull request Sep 30, 2024
Closed
@thewhaleking thewhaleking linked an issue Sep 30, 2024 that may be closed by this pull request
btcli root list-delegates help: implies the ability to filter by wallet, yet not an option #138
Closed
rajkaramchedu
rajkaramchedu approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@rajkaramchedu rajkaramchedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks!

@ibraheem-opentensor ibraheem-opentensor merged commit 5c7bf0a into opentensor:staging Oct 1, 2024
1 check failed
@ibraheem-opentensor ibraheem-opentensor mentioned this pull request Oct 2, 2024
Merged
@thewhaleking thewhaleking mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkaramchedu rajkaramchedu rajkaramchedu approved these changes

@galina-opentensor galina-opentensor Awaiting requested review from galina-opentensor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

btcli root list-delegates help: implies the ability to filter by wallet, yet not an option
3 participants
@dougsillars @rajkaramchedu @ibraheem-opentensor