Skip to content

Conversation

@ibraheem-abe
Copy link
Contributor

@ibraheem-abe ibraheem-abe commented Nov 28, 2025

Added MeV shield to

  • Add stake, add stake limit
  • Remove stake, remove stake limit
  • Move stake extrinsics
  • SN creation

After successful submission, the commands wait and confirm that the extrinsic was actually executed after the shield wrapper is decrypted on the chain.

TODOs:

  • Update nonce logic once its updated upstream on the chain (current implementation does work as is though)
  • Add support upstream in ASI for the MeV extrinsic
  • Update/add E2E tests to handle new logic

Note: Tests as expected to fail until drand update is released and some of them updated
Dependent on the release of:

ASI 1.5.13
bittensor-drand 1.2.0

Update: Both ASI and drand versions are released and dependencies updated

@ibraheem-abe ibraheem-abe added enhancement New feature or request Do not merge labels Nov 28, 2025
@ibraheem-abe ibraheem-abe requested a review from a team November 28, 2025 06:59
thewhaleking
thewhaleking previously approved these changes Nov 28, 2025
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would mark ASI as >= 1.5.13 and wait to release til after release of ASI 1.5.13

@thewhaleking
Copy link
Contributor

opentensor/async-substrate-interface#245

@thewhaleking
Copy link
Contributor

@ibraheem-abe is this test failure in the sn creation part of test_wallet_identities due to a fast-blocks issue?

basfroman
basfroman previously approved these changes Dec 3, 2025
@ibraheem-abe
Copy link
Contributor Author

@thewhaleking
Yess. I converted it to non-fast-blocks but in it, we need to wait a little while before creating the subnet.
Current behaviour was flaky - sometimes works sometimes doesn't.

I converted it to non-fast blocks again with --no-mev-protection. We're already testing the shield in couple of other tests.

Seems to be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants