-
Notifications
You must be signed in to change notification settings - Fork 48
Feat: MeV protection in staking operations #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
thewhaleking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would mark ASI as >= 1.5.13 and wait to release til after release of ASI 1.5.13
|
@ibraheem-abe is this test failure in the sn creation part of test_wallet_identities due to a fast-blocks issue? |
|
@thewhaleking I converted it to non-fast blocks again with Seems to be good now |
Added MeV shield to
After successful submission, the commands wait and confirm that the extrinsic was actually executed after the shield wrapper is decrypted on the chain.
TODOs:
Update nonce logic once its updated upstream on the chain (current implementation does work as is though)Add support upstream in ASI for the MeV extrinsicUpdate/add E2E tests to handle new logicNote: Tests as expected to fail until drand update is released and some of them updated
Dependent on the release of:
Update: Both ASI and drand versions are released and dependencies updated