Skip to content

Conversation

@sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Feb 6, 2025

What's Changed

camfairchild and others added 30 commits January 27, 2025 12:43
Ban saturating_div, to_num, and from_num
…n-hk-swap

Fix/swap pending childkeys on hk swap
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
unconst and others added 26 commits February 7, 2025 14:18
[RAO Ugrade] Devnet-ready -> Devnet
add moving price to metagraph
* use correct min brun init

* fmt

* no into

* no into 2

* bump spec
[RAO Upgrade] devnet-ready -> devnet
devnet deploy 2/7/2025 number 2
testnet deploy 2/7/2025 number two
moving price init from emission
testnet deploy 2/7/2025 again again again
…gration

DefaultMinimumPoolLiquidity and tempos in rao migration
netuid_to_register,
mechid
);
Self::deposit_event(Event::NetworkAdded(netuid_to_register, 0));
Copy link
Contributor

@bdmason bdmason Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second parameter should be using the mechid variable else the information from the emitted events will be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. will add into devnet-ready for the next runtime upgrade (after dTAO)

#[pallet::storage] // --- MAP ( netuid ) --> alpha_out_emission | Returns the amount of alpha out emission into the network per block.
pub type SubnetAlphaOutEmission<T: Config> =
StorageMap<_, Identity, u16, u64, ValueQuery, DefaultZeroU64<T>>;
#[pallet::storage] // --- MAP ( netuid ) --> tao_in_emission | Returns the amount of tao emitted into this subent on the last block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[pallet::storage] // --- MAP ( netuid ) --> tao_in_emission | Returns the amount of tao emitted into this subent on the last block.
#[pallet::storage] // --- MAP ( netuid ) --> tao_in_emission | Returns the amount of tao emitted into this subnet on the last block.

Comment on lines +1060 to +1064
pub type TokenSymbol<T: Config> =
StorageMap<_, Identity, u16, Vec<u8>, ValueQuery, DefaultUnicodeVecU8<T>>;
#[pallet::storage] // --- MAP ( netuid ) --> subnet_name | Returns the name of the subnet.
pub type SubnetName<T: Config> =
StorageMap<_, Identity, u16, Vec<u8>, ValueQuery, DefaultUnicodeVecU8<T>>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use BoundedVec for storage items like these

@garrett-opentensor garrett-opentensor merged commit e2b8367 into main Feb 13, 2025
38 of 39 checks passed
@camfairchild camfairchild mentioned this pull request Feb 26, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.