Skip to content

Conversation

@open-junius
Copy link
Contributor

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Mar 18, 2025
@open-junius open-junius changed the title add evm test to ci [WIP] add evm test to ci Mar 18, 2025
@open-junius open-junius added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Apr 3, 2025
@open-junius open-junius changed the title [WIP] add evm test to ci add evm test to ci Apr 3, 2025
Copy link
Contributor

@ales-otf ales-otf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor stuff from me, feel free to ignore if you wish

@open-junius open-junius added no-spec-version-bump PR does not contain changes that requires bumping the spec version and removed no-spec-version-bump PR does not contain changes that requires bumping the spec version labels Apr 7, 2025
@open-junius open-junius requested review from ales-otf and l0r1s April 8, 2025 10:15
Comment on lines 5 to 10
branches:
- devnet
- devnet-ready
- testnet
- testnet-ready
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just take out this entire line, we want it to run on all PRs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad then @open-junius ! Sorry for the change!

Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-junius
Copy link
Contributor Author

Please restrict branches to trigger https://github.com/opentensor/subtensor/pull/1422/files#r2039631846

#1422 (comment) please check this comment.

@sam0x17 sam0x17 merged commit 2a4c994 into devnet-ready Apr 11, 2025
51 checks passed
This was referenced Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants