-
Notifications
You must be signed in to change notification settings - Fork 251
Fix NetUid metadata issue #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
876454e to
0d924bf
Compare
38ea027 to
16488f4
Compare
|
I'm gonna merge it, the failures are all related to the current network outages going on in public clouds |
I don't believe the e2e failures are related to network outages: These seem related to the same type issues as previously. |
|
converted to draft, to prevent merging |
hmm this looks like some other type. even more interesting, that with a locally running node all the tests passed. well, at least e2e from btcli, which failed here... |
|
are we sure CI runs on this branch's node?
ok, it looks like it's all tests pass. but if you add UPD hmm no, local errors are not the same. local errors related to json decoding from color/rich output from my terminal. it looks like the tests rely on stdout parsing. figuring out how to workaround it. because it seems that the tests are running on a node without this fix. for example, it tries to decode something like this, when I run it locally:
|
Description
Turns out
NetUidtype in metadata represented as a wrapper aroundu16. This PR fixes it by manual implementation ofTypeInfoto makeNetUidhave the same type id asu16.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.