-
Notifications
You must be signed in to change notification settings - Fork 251
Correct the as-bytes version of various symbols. #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the as-bytes version of various symbols. #2037
Conversation
|
Looks like there's some test failures. Hmm. |
|
Much of CI can be fixed with |
|
Looks like there's duplicate symbols: Considered using the ඤ symbol that actually maps to Will check |
l0r1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will require a migration given some symbol in use with netuid < 128 have been modified
In this case, should I update the comment for lines <128, and leave the as-bytes as-is for those? |
As you prefer, if you want to modify the symbol itself, you can take example on this migration but just over the symbol for uids that needs to be modifed and not all uids. Updating the comment is probably the easy path here |
l0r1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs migration for the 2 symbols
Description
The as-bytes versions of a number of symbols did not reflect what the comment suggested. This corrects those.
The only symbols that changed were:
b"\xE0\xB6\xA7", // ට (Ta, 430), switched tob"\xE0\xB6\xA9", // ඩ (Dha, 430)Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.