Skip to content

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Sep 9, 2025

Description

The as-bytes versions of a number of symbols did not reflect what the comment suggested. This corrects those.

The only symbols that changed were:

  • a duplicate 430/427 that was b"\xE0\xB6\xA7", // ට (Ta, 430), switched to b"\xE0\xB6\xA9", // ඩ (Dha, 430)
  • 86 had the comment of ᚲ, but the unicode bytes (and comment name) for ᚳ
  • 116 had the comment of ъ, but the unicode bytes (and comment name) for Ъ
  • 128 had the comment of ඲, but the unicode bytes (and comment name) for න

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@thewhaleking thewhaleking requested a review from a team September 9, 2025 22:06
@thewhaleking
Copy link
Contributor Author

Looks like there's some test failures. Hmm.

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Sep 9, 2025
@sam0x17
Copy link
Contributor

sam0x17 commented Sep 9, 2025

Much of CI can be fixed with ./scripts/fix_rust.sh

@thewhaleking
Copy link
Contributor Author

thewhaleking commented Sep 9, 2025

Looks like there's duplicate symbols:

b"\xE0\xB6\xA7", // ට (Ta, 427)
b"\xE0\xB6\xA7", // ට (Dha, 430)

Considered using the ඤ symbol that actually maps to b"\xE0\xB6\xA4", but that is already used by 426.

Will check test_register_network_use_symbol_for_subnet_if_available to fix tomorrow.

Copy link
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will require a migration given some symbol in use with netuid < 128 have been modified

@thewhaleking
Copy link
Contributor Author

it will require a migration given some symbol in use with netuid < 128 have been modified

In this case, should I update the comment for lines <128, and leave the as-bytes as-is for those?

@l0r1s
Copy link
Collaborator

l0r1s commented Sep 10, 2025

In this case, should I update the comment for lines <128, and leave the as-bytes as-is for those?

As you prefer, if you want to modify the symbol itself, you can take example on this migration but just over the symbol for uids that needs to be modifed and not all uids.

Updating the comment is probably the easy path here

@thewhaleking thewhaleking requested review from a team and l0r1s September 11, 2025 19:51
Copy link
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs migration for the 2 symbols

@thewhaleking thewhaleking requested review from a team and l0r1s September 12, 2025 15:12
@thewhaleking thewhaleking requested a review from a team September 16, 2025 14:35
@sam0x17 sam0x17 merged commit 01c90a7 into devnet-ready Sep 16, 2025
88 of 91 checks passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/correct-symbols-bytes branch September 16, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants