Add migration for RateLimitKey #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-otf
added
the
skip-cargo-audit
gztensor
approved these changes
Oct 20, 2025
sam0x17
approved these changes
Oct 20, 2025
JohnReedV
approved these changes
Oct 20, 2025
l0r1s
reviewed
Oct 20, 2025
Comment on lines
2296
to
2314
| pub enum RateLimitKey<AccountId> { | ||
| // The setting sn owner hotkey operation is rate limited per netuid | ||
| #[codec(index = 0)] | ||
| SetSNOwnerHotkey(NetUid), | ||
| // Generic rate limit for subnet-owner hyperparameter updates (per netuid) | ||
| #[codec(index = 1)] | ||
| OwnerHyperparamUpdate(NetUid, Hyperparameter), | ||
| // Subnet registration rate limit | ||
| #[codec(index = 2)] | ||
| NetworkLastRegistered, | ||
| // Last tx block limit per account ID | ||
| #[codec(index = 3)] | ||
| LastTxBlock(AccountId), | ||
| // Last tx block child key limit per account ID | ||
| #[codec(index = 4)] | ||
| LastTxBlockChildKeyTake(AccountId), | ||
| // Last tx block delegate key limit per account ID | ||
| #[codec(index = 5)] | ||
| LastTxBlockDelegateTake(AccountId), |
Collaborator
There was a problem hiding this comment.
Are the explicit indexes needed given there are no gaps?
Contributor
Author
There was a problem hiding this comment.
I added them to prevent mistakes like I made in the future
l0r1s
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to migrate
RateLimitKeyvariants because of this change to prevent decoding issue. This PR adds the migration.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.