Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ip6] remove UDP port check for messages with HostTrusted origin #10546

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

abtink
Copy link
Member

@abtink abtink commented Jul 25, 2024

This commit removes the checks previously performed on messages with the origin HostTrusted that are to be forwarded to the Thread mesh. This origin is used for messages generated by the OpenThread stack itself. These checks were unnecessarily restricting such messages from using Thread Control UDP port numbers (like TMF, MLE, etc.). The additional check !IsLoopbackToHostAllowed() (which is set to true by default on such messages) bypassed the entire block, preventing any functional impact.

Recent related changes (in #9437) added similar guard checks for messages with HostUntrusted origins.


Related to #10543

This commit removes the checks previously performed on messages with
the origin `HostTrusted` that are to be forwarded to the Thread mesh.
This origin is used for messages generated by the OpenThread stack
itself. These checks were unnecessarily restricting such messages
from using Thread Control UDP port numbers (like TMF, MLE, etc.).
The additional check `!IsLoopbackToHostAllowed()` (which is set to
`true` by default on such messages) bypassed the entire block,
preventing any functional impact.

Recent related changes (in openthread#9437) added similar guard checks for
messages with `HostUntrusted` origins.
Copy link

size-report bot commented Jul 25, 2024

Size Report of OpenThread

Merging #10546 into main(2cc0798).

name branch text data bss total
ot-cli-ftd main 467240 856 66364 534460
#10546 467160 856 66364 534380
+/- -80 0 0 -80
ot-ncp-ftd main 436316 760 61592 498668
#10546 436236 760 61592 498588
+/- -80 0 0 -80
libopenthread-ftd.a main 236580 95 40302 276977
#10546 236496 95 40302 276893
+/- -84 0 0 -84
libopenthread-cli-ftd.a main 57580 0 8075 65655
#10546 57580 0 8075 65655
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 32127 0 5924 38051
#10546 32127 0 5924 38051
+/- 0 0 0 0
ot-cli-mtd main 365504 760 51236 417500
#10546 365424 760 51236 417420
+/- -80 0 0 -80
ot-ncp-mtd main 348220 760 46480 395460
#10546 348124 760 46480 395364
+/- -96 0 0 -96
libopenthread-mtd.a main 159003 0 25190 184193
#10546 158919 0 25190 184109
+/- -84 0 0 -84
libopenthread-cli-mtd.a main 39795 0 8059 47854
#10546 39795 0 8059 47854
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 25007 0 5924 30931
#10546 25007 0 5924 30931
+/- 0 0 0 0
ot-cli-ftd-br main 552016 864 131228 684108
#10546 551920 864 131228 684012
+/- -96 0 0 -96
libopenthread-ftd-br.a main 325501 100 105142 430743
#10546 325413 100 105142 430655
+/- -88 0 0 -88
libopenthread-cli-ftd-br.a main 71711 0 8099 79810
#10546 71711 0 8099 79810
+/- 0 0 0 0
ot-rcp main 62328 564 20636 83528
#10546 62328 564 20636 83528
+/- 0 0 0 0
libopenthread-rcp.a main 9734 0 5060 14794
#10546 9734 0 5060 14794
+/- 0 0 0 0
libopenthread-radio.a main 19031 0 222 19253
#10546 19031 0 222 19253
+/- 0 0 0 0

@abtink abtink marked this pull request as ready for review July 25, 2024 23:52
@jwhui jwhui merged commit 736bd18 into openthread:main Jul 30, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ip6] extra checks for ShouldUsePlatformUdp() before forwarding to Thread mesh
2 participants