Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[posix] add multicast address update in netif module #2447

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR addes multicast addresses update method of Netif module.

This PR contains a small unit test case to verify the implementation.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 62.03704% with 41 lines in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (2b41187) to head (5cd4f85).
Report is 774 commits behind head on main.

Files Patch % Lines
tests/gtest/test_netif.cpp 60.25% 26 Missing and 5 partials ⚠️
src/ncp/posix/netif.cpp 66.66% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2447       +/-   ##
===========================================
- Coverage   55.77%   45.76%   -10.01%     
===========================================
  Files          87       99       +12     
  Lines        6890    11442     +4552     
  Branches        0      829      +829     
===========================================
+ Hits         3843     5237     +1394     
- Misses       3047     5943     +2896     
- Partials        0      262      +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch from c37235f to c253b21 Compare August 21, 2024 06:02
@Irving-cl Irving-cl marked this pull request as draft August 21, 2024 12:39
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch 2 times, most recently from 253ed19 to 7fc9f8f Compare August 22, 2024 01:22
@Irving-cl Irving-cl marked this pull request as ready for review August 22, 2024 01:22
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. 👍
Two smaller (optional) suggestions below.

src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch from 7fc9f8f to 94b99e9 Compare August 23, 2024 01:18
@Irving-cl Irving-cl requested a review from sunytt August 23, 2024 01:19
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch 2 times, most recently from bb5b71f to baa4f8c Compare August 23, 2024 02:10
@Irving-cl Irving-cl removed the request for review from bukepo August 23, 2024 05:57
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch from baa4f8c to d09ae7c Compare August 23, 2024 07:08
src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
tests/gtest/test_netif.cpp Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch 2 times, most recently from 9ca4ccb to dac78eb Compare August 26, 2024 02:49
@Irving-cl Irving-cl requested a review from sunytt August 26, 2024 02:50
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch from dac78eb to e1c99d5 Compare August 26, 2024 03:11
@Irving-cl Irving-cl requested a review from sunytt August 26, 2024 03:13
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_update branch from e1c99d5 to 5cd4f85 Compare August 26, 2024 03:44
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui August 26, 2024 06:31
@jwhui jwhui merged commit 626b3f5 into openthread:main Aug 26, 2024
32 checks passed
@Irving-cl Irving-cl deleted the posix_netif_mcast_addr_update branch August 27, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants