Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[posix] add netif SetState #2453

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

Irving-cl
Copy link
Contributor

This PR adds the SetState for Netif module to set the interface ON/OFF.

In this PR this hasn't been integrated with NCP yet. (After receiving NCP property update, the state of wpan interface changed accordingly). This will be done later.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.60%. Comparing base (2b41187) to head (ab990bb).
Report is 776 commits behind head on main.

Files Patch % Lines
src/ncp/posix/netif.cpp 46.66% 6 Missing and 2 partials ⚠️
tests/gtest/test_netif.cpp 64.70% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2453       +/-   ##
===========================================
- Coverage   55.77%   45.60%   -10.17%     
===========================================
  Files          87       99       +12     
  Lines        6890    11526     +4636     
  Branches        0      832      +832     
===========================================
+ Hits         3843     5257     +1414     
- Misses       3047     6004     +2957     
- Partials        0      265      +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Irving-cl Irving-cl requested a review from jwhui August 24, 2024 02:18
src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
@jwhui jwhui merged commit 6ab1a47 into openthread:main Aug 27, 2024
32 checks passed
@Irving-cl Irving-cl deleted the posix_netif_set_state branch September 5, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants