Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] integrate netif multicast address update #2460

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR integrates Netif multicast address update with NcpSpinel so that wpan will join the multicast group that NCP joins.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (2b41187) to head (1aa4a87).
Report is 780 commits behind head on main.

Files Patch % Lines
src/ncp/ncp_spinel.cpp 0.00% 17 Missing ⚠️
src/ncp/ncp_host.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2460       +/-   ##
===========================================
- Coverage   55.77%   45.31%   -10.47%     
===========================================
  Files          87       99       +12     
  Lines        6890    11558     +4668     
  Branches        0      833      +833     
===========================================
+ Hits         3843     5237     +1394     
- Misses       3047     6054     +3007     
- Partials        0      267      +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ncp/ncp_spinel.hpp Outdated Show resolved Hide resolved
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

src/ncp/ncp_spinel.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the posix_netif_mcast_addr_ncp branch 3 times, most recently from fde7f85 to b4723f8 Compare August 28, 2024 02:00
@Irving-cl Irving-cl requested a review from jwhui August 28, 2024 02:00
@jwhui jwhui merged commit 180e27b into openthread:main Aug 28, 2024
32 checks passed
@Irving-cl Irving-cl deleted the posix_netif_mcast_addr_ncp branch September 5, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants