fix: better logic of load boosted boss function #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of custom servers with few monsters (such as pack canary) the server will not enter a loop if there are not enough bosses registered or if there is no boss archfoe.
murilo09
approved these changes
Apr 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
libergod
referenced
this pull request
in libergod/canary_baiak
Apr 24, 2023
libergod
referenced
this pull request
in libergod/canary_baiak
Jun 2, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
In case of custom servers with few monsters (such as pack canary) the server will not enter a loop if there are not enough bosses registered or if there is no boss with race archfoe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of custom servers with few monsters (such as pack canary) the server will not enter a loop if there are not enough bosses registered or if there is no boss archfoe.
Behaviour
Actual
If you don't have a boss archfoe registered or more than one boss registered, the server goes into a loop
Expected
It sends an error stating that there is no boss registered and continues to load normally.
Type of change
How Has This Been Tested
Open the pack without any bosses or without Archfoe race bosses, the server will enter a loop when loading boosted bosses.
Test Configuration:
Checklist