fix: possible nil table on useStamina function #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlospess0a
approved these changes
Apr 19, 2023
beats-dh
approved these changes
Apr 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
libergod
referenced
this pull request
in libergod/canary_baiak
Apr 24, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
In some scenario where the player is no longer online, but the event is still running, it will give a nil value error when trying to access the table with the player ID, generating the "nil value" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some scenario where the player is no longer online, but the event is still running, it will give a nil value error when trying to access the table with the player id, generating the "nil value" error.
Behaviour
Actual
An error occurs when trying to access the table with the player online.
Expected
No error happens.
Type of change
How Has This Been Tested
It's something that doesn't happen very often, it just happens to happen that the player is no longer online but the stamina event is still running.
Checklist