feat: sound effects system

[marcosvf132]

Co-Author

@dudantas
Client: https://github.com/dudantas/tibia-client/releases/tag/13.16.13209

Old PR

Old PR changes moved to this one to separate features by commits

Preview

Tibia.-.Marcos.Teste.2022-09-30.11-04-06.mp4

13.10

WIP

• This PR implement a huge amount of features ingame that need time and test to verify all of then and to adjust the details on it.

Musics and anthem

• Musics and anthem are not on this PR yet because i'm still catalogating then all, check for further commits on this PR.

Features implemented so far

Player combat

• Player weapon sounds are implemented, with future adjustments like a specifc sound on a different item.
• Wand and rods so far have the same sound, which will be changed on the next commits.

Monster combat

• There is a script that run on monster spell declarations that automaticlly detect which spell sound it should be.
• If the user want's to select a custom sound to a spell, can use the following tags:
  
  

Item movement

• All items have sound on their movement, some can have the wrong sound, if you know an item that does not have the sound so accurated, please help me improving it.

Npc sounds

• The NPC Canary does emit sounds on his sourrounds, check the new functions label on this description for more information.

New function

Enums

• We have a LOT of sounds on tibia (512 so far), all those sounds are catalogated on the /src/creatures/creatures_definitions.hpp file, rigth here:
  

NOTE: You can use then all on LUA env

C++

Sound movement

• The item sound movement comes from this new function, based on item loot category. I know this is not 100% accurated but its the best shot so far.
• The sound can change if the it's is being moved inside depot or player backpacks/inventory on the game.cpp call.
  

Sound notification to spectators

• On this topic we have 2 new functions, the first one is used to send a unique sound to the spectators on the area. It already check the sound source if it's coming from the own player, other player, a creature or it's meant to be a global sound. This source type is used on the client to balance and mix the volume as the player desire.
  
• This second function is used on distance weapons or any other sound that must be reproduced on a sequence. Like a casting sound and an impact sound.
  

OnThink sounds

• Some creatures emits sounds while in battle or when you get close to then. The first function is for the NPCs:
  
• The monsters sounds:
  

Player client functions

• The player.h functions are used to send the sound to the client, can be used to send a sound directly to the player client and not send to all the players on the area.
  

Player sound functions

• Functions that return the sound ID by the weapond attack and impact sound.
• Impact function:
  
• Attack function:
  

LUA

Spell (local spell = Spell("spell"))

• We have the possibility to add sounds on the spell, can be the sound when casting the spell AND the sound when the spell hits the target/area.
• Casting sound:
  
• Impact sound:
  

Bestiary charm

• We have the possibility to add sounds on the spell, can be the sound when casting the spell AND the sound when the spell hits the target/area.
  

Npc

• You can add sound effects on the NPC just like the old text system, can be used as a environment sound as a blacksmith sound, hitting a wood, casting a spell etc.
• A random sound will be picked on the list to be reproduced.
  

Position

• You can used this function to send sounds on the specific position, just like the position:sendMagicEffect(...)
  
  

The optional 'actor' on this function right here can be used to specify if you want to send the sound pretending is was coming from the creature. If you don't send a creature on the param, it will be sent as a global sound.

XML

• The imbuement system can emits sounds too, you can set a sound on the imbuements.xml files be using the id:
  

[vitorfrancisco]

13.11 ou 13.10 pra fazer funcionar? to tomando crash no 13.11

[elsongabriel]

13.11 ou 13.10 pra fazer funcionar? to tomando crash no 13.11

então mano. teve uma atualização na main, que mudou a versão 12.91 para 13.16.
consequentemente o client 13.11 e 13.10, não vai mais permitir logar-se.

o PR anterior #531 foi fechado, e novos PR's com as funcionalidades do client 13 foram abertos.

[dudantas]

13.11 ou 13.10 pra fazer funcionar? to tomando crash no 13.11

13.16

[Issolofreedom]

Sons dos potions não estão saindo.

[Issolofreedom]

NPC Chuckles em yalahar fazendo o client crashar

[QuebradaZN]

NPC Chuckles em yalahar fazendo o client crashar

Testei lá e aqui não aconteceu.

Aqui tambem, testei e não crashou o Client!

[LeoBorges18]

NPC Chuckles em yalahar fazendo o client crashar

Testei aqui e não crashou tb

[dudantas]

Sons dos potions não estão saindo.

Isto vai ficar para depois.. Aparentemente o id do som está errado, se alguém souber o id me avisa.

[QuebradaZN]

Sons dos potions não estão saindo.

Isto vai ficar para depois.. Aparentemente o id do som está errado, se alguém souber o id me avisa.

Dos Foods Tambem não!

[elsongabriel]

testado.. e agora tá ok..

[Lanemosme]

Pessoal, andei fazendo uns testes aqui, e o cliente tá crashando quando usado uma mana potion, e algo bem aleatório, as vezes crasha e as vezes não, mais alguém passando por isso?

[dudantas]

Pessoal, andei fazendo uns testes aqui, e o cliente tá crashando quando usado uma mana potion, e algo bem aleatório, as vezes crasha e as vezes não, mais alguém passando por isso?

Aqui não tive isso. Não sei se faz sentido também, porque a alteração que teve foi o som, aí daria debug sempre. Você ta usando a branch limpa? Client 13.16?

[Lanemosme]

Pessoal, andei fazendo uns testes aqui, e o cliente tá crashando quando usado uma mana potion, e algo bem aleatório, as vezes crasha e as vezes não, mais alguém passando por isso?

Aqui não tive isso. Não sei se faz sentido também, porque a alteração que teve foi o som, aí daria debug sempre. Você ta usando a branch limpa? Client 13.16?

Acabei de atualizar tudo aqui, já testei também, problema resolvido 👊🏻

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells

0.0% Coverage
2.4% Duplication