Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give party leader dust and share regardless of damage #1020

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix: give party leader dust and share regardless of damage #1020

merged 1 commit into from
Apr 27, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Apr 26, 2023

Description

Add party leader to list of dust-receiving characters, and loop over members instead of killers.

Behaviour

Actual

Killing a forge creature while party sharing is active wasn't giving dust to the party leader.

Expected

From wiki:

Each such party member gets the same amount of Dust a single player would get if they killed the creature by themselves, without being in a party. In other words, there is no downside to "sharing" Dust in this manner.

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tried killing forge creatures while not in a party
  • Killed forge creatrues in a party (active share and inactive) with 2 and 3 players

Test Configuration:

  • Server Version: latest main
  • Client: 13.16
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

From wiki: 
>  Each such party member gets the same amount of Dust a single player would get if they killed the creature by themselves, without being in a party. In other words, there is no downside to "sharing" Dust in this manner.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 099034f into opentibiabr:main Apr 27, 2023
@dudantas dudantas changed the title fix(forge): give party leader dust and share regardless of damage fix: give party leader dust and share regardless of damage Apr 27, 2023
luan added a commit that referenced this pull request Jul 11, 2023
Add party leader to list of dust-receiving characters, and loop over members instead of killers.
@luan luan deleted the patch-1 branch October 21, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants