Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emote spells validation and storage conflict #1062

Merged
merged 2 commits into from
May 9, 2023
Merged

fix: emote spells validation and storage conflict #1062

merged 2 commits into from
May 9, 2023

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented May 5, 2023 •
edited
Loading

Description

Adjusted function to show or not the spells emoted, set by the player.

before:
image

after:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary
  • Client: 13.16
  • Operating System: Ubuntu 22.04

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel changed the title fix: emote-spells fix: emote spells May 5, 2023
travisani
travisani approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@travisani travisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working but this looks a good Enhancement no ?

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 3e81ab6 into opentibiabr:main May 9, 2023
@dudantas dudantas changed the title fix: emote spells fix: emote spells validation and storage conflict May 9, 2023
libergod referenced this pull request in libergod/canary_baiak May 30, 2023
@libergod
fix: emote spells validation and storage conflict #1062
fa5b1c3
luan pushed a commit that referenced this pull request Jul 11, 2023
@elsongabriel
fix: emote spells validation and storage conflict (#1062)
2b3ebb8
@elsongabriel elsongabriel deleted the fix/emote-spells branch August 10, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@travisani travisani travisani approved these changes

@victortp victortp victortp approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@QuebradaZN QuebradaZN QuebradaZN approved these changes

Assignees
No one assigned
Labels
Area: Datapack Global Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elsongabriel @dudantas @travisani @victortp @majestyotbr @QuebradaZN