fix: crash related to getName methods with deleted creature #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they are classes with virtual implementations, after the creature is deleted it crashes when trying to access the wrong getName methods. Doing the manual implementations of each class solves the problem of crashing in an addEvent lua.
hriqueXimenes
approved these changes
May 8, 2023
elsongabriel
approved these changes
May 8, 2023
majestyotbr
approved these changes
May 9, 2023
beats-dh
approved these changes
May 9, 2023
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
libergod
referenced
this pull request
in libergod/canary_baiak
May 31, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Because they are classes with virtual implementations, after the creature is deleted it crashes when trying to access the wrong getName methods. Doing the manual implementations of each class solves the problem of crashing in an addEvent lua.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because they are classes with virtual implementations, after the creature is deleted it crashes when trying to access the wrong getName methods. Doing the manual implementations of each class solves the problem of crashing in an addEvent lua.
Resolves #513
Behaviour
Actual
Crashes when trying to access a monster/player that has already been deleted from memory through the lua Creature(name or id) method.
Expected
No more crash.
Type of change