fix: possible crash related to unsafe "getTile" #1095
Merged
+93
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
fix-get-tile-crash
branch
from
3136008 to
4efa3e9
Compare
beats-dh
approved these changes
May 15, 2023
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
murilo09
changed the title
enzerah
pushed a commit
to enzerah/canary
that referenced
this pull request
May 21, 2023
This change aims to validate some "getTile" functions to prevent rare crashes that may occur in specific scenarios. These crashes are more likely to happen in test environments than in production. Although we could only reproduce one of the crashes, validating these functions is essential since they involve pointers that can occasionally return nullptr. The most critical areas to focus on are the getTile function in creature.h and the Game::playerMoveItem function, as they pose a higher risk.
enzerah
pushed a commit
to enzerah/canary
that referenced
this pull request
May 21, 2023
This change aims to validate some "getTile" functions to prevent rare crashes that may occur in specific scenarios. These crashes are more likely to happen in test environments than in production. Although we could only reproduce one of the crashes, validating these functions is essential since they involve pointers that can occasionally return nullptr. The most critical areas to focus on are the getTile function in creature.h and the Game::playerMoveItem function, as they pose a higher risk.
libergod
referenced
this pull request
in libergod/canary_baiak
May 31, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
This change aims to validate some "getTile" functions to prevent rare crashes that may occur in specific scenarios. These crashes are more likely to happen in test environments than in production. Although we could only reproduce one of the crashes, validating these functions is essential since they involve pointers that can occasionally return nullptr. The most critical areas to focus on are the getTile function in creature.h and the Game::playerMoveItem function, as they pose a higher risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
• Need tests
This change aims to validate some "getTile" functions to prevent rare crashes that may occur in specific scenarios. These crashes are more likely to happen in test environments than in production.
Although we could only reproduce one of the crashes, validating these functions is essential since they involve pointers that can occasionally return nullptr.
The most critical areas to focus on are the getTile function in creature.h and the Game::playerMoveItem function, as they pose a higher risk.