fix: clone exit and not removing the player on the death screen #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
May 22, 2023
jacksonie
suggested changes
May 22, 2023
…ame instead of object
dudantas
force-pushed
the
fix-clone-exit-and-not-removing-the-player-on-the-death-screen-
branch
from
83a3f23 to
9c8b3a7
Compare
dudantas
force-pushed
the
fix-clone-exit-and-not-removing-the-player-on-the-death-screen-
branch
from
ffb5e3f to
18d8746
Compare
…n-the-death-screen-
dudantas
approved these changes
May 22, 2023
|
Tested, apparently everything is ok. |
dudantas
force-pushed
the
fix-clone-exit-and-not-removing-the-player-on-the-death-screen-
branch
from
d8428c5 to
647e9b4
Compare
jacksonie
approved these changes
May 23, 2023
|
Tested:
|
|
Kudos, SonarCloud Quality Gate passed! |
carlospess0a
approved these changes
May 23, 2023
dudantas
deleted the
fix-clone-exit-and-not-removing-the-player-on-the-death-screen-
branch
libergod
referenced
this pull request
in libergod/canary_baiak
Jun 1, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fixed: • Force exit then log in with another client; • Force exit death screen and log in with another client; • Getting idle on the death screen; • Die, stay on the death screen, then very quickly log in with a 2nd client on top of the char; • Get pk, exit and wait to die, then cannot login, get message "You already login".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
Test Ctrl + Q "cannot be a clone of the player".
Test Ctrl + C, "there can be no player clone".
Exit the client with the player online, and log in again "there cannot be a clone of the player".
Die with the player and see if it will log out after spending time configuring it in config.lua, change the variable "kickIdlePlayerAfterMinutes" to a shorter time in config.lua.