Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helmets and hats #1159

Merged
merged 4 commits into from
Jun 7, 2023
Merged

fix: helmets and hats #1159

merged 4 commits into from
Jun 7, 2023

Conversation

Valleze
Copy link
Contributor

@Valleze Valleze commented Jun 5, 2023

Description

  • Fixado o peso do item Ancient Tiara: de 819 para 820;
  • Removido imbuement slot do item Chain Helmet;
  • Removido o atributo defense do item Crown;
  • Adicionado atributo +2 de ml no item Eldritch Cowl;
  • Adicionado atributo +2 de ml no item Eldritch Hood;
  • Fixado as restrições de vocações do item Enchanted Werewolf Helmet (estavam todas invertidas). Adicionado ao nome de identificação de cada um, o bonus deles de acordo com o que está em items.xml, para facilitar a identificação;
  • Fixado o nome do item de id 3230: de Helmet of the Ancients para Full Helmet of the Ancients;
  • Fixado atributo arm do Gnome Helmet: de 7 para 8;
  • Adicionado Green Demon Helmet no arquivo unscripted_equipments.lua;
  • Fixado o atributo armor do item Helmet of the Ancients: de 11 para 8.
  • Fixado id do item Mining Helmet, em unscripted_equipments.lua: de 139 paa 875 (139 é o item que fica com o NPC, e o mesmo não pode ser equipado no char, em troca ele te dá o 875. Ambos são a mesma sprite);
  • Adicionado atributo de absorção de 3% de dano no elemento death no item: Shroud of Despair, id: 22757;
  • Fixado speed bonus do item Tiara of Power: de 10 para 20;
  • Adicionado o item: Traditional Gamsbart Hat, id: 32100 no arquivo unscripted_equipments.lua;

Behaviour

Actual

Alguns helmets com atributos errados / faltando / a mais.

Expected

Editei conforme o global, deixando mais fiel ao mesmo.

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Observei as diferenças, conforme fui pesquisando por cada um deles.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@murilo09 murilo09 changed the title Fix helmets and hats fix: helmets and hats Jun 5, 2023
@duuh30
Copy link
Contributor

duuh30 commented Jun 6, 2023

@Valleze da uma verificada e corrige por favor o unscripted para que os item_id mais novos fiquem em cima, a ordem é decrescente!

@Valleze
Copy link
Contributor Author

Valleze commented Jun 6, 2023

@duuh30 poderia verificar se está correto agora? Eu tinha adicionado apenas 3 itens ao arquivo: Green Demon Helmet, Enchanted Werewolf Helmet - sword e Traditional Gamsbart Hat.

Agora arrumei também o nome do Enchanted Werewolf Helmet - sword. Estava como amulet. Peço desculpas pelos erros.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dudantas dudantas merged commit 43ddb27 into opentibiabr:main Jun 7, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
@Valleze
fix: helmets and hats attributes (#1159)
29e8f53 
• Fixed weight of "ancient tiara": from 819 to 820;
• Removed imbuement slot from "chain helmet";
• Removed defense attribute from "crown" item;
• Added +2 ml attribute to "eldritch cowl";
• Added +2 ml attribute to "eldritch hood";
• Fixed vocation restrictions of "enchanted werewolf helmet" (were all inverted). Added identification bonus to each item's name based on items.xml for easier identification;
• Fixed item name with ID 3230: changed from "helmet of the ancients" to "full helmet of the ancients";
• Fixed arm attribute of "gnome helmet": from 7 to 8;
• Added "green demon helmet" to unscripted_equipments.lua file;
• Fixed armor attribute of "helmet of the ancients": from 11 to 8.
• Fixed Mining Helmet item ID in unscripted_equipments.lua: changed from 139 to 875 (139 is the item held by the NPC and cannot be equipped, instead it gives you item 875. Both have the same sprite);
• Added 3% death damage absorption attribute to "shroud of despair", ID: 22757;
• Fixed speed bonus of "tiara of power": from 10 to 20;
• Added item "traditional gamsbart hat", ID: 32100 to unscripted_equipments.lua file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@duuh30 duuh30 duuh30 approved these changes

Assignees
No one assigned
Labels
Area: Datapack Core Area: Datapack Global
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Valleze @duuh30 @dudantas