fix: fishing skill

[pess0a]

Description

Change if order to validate worms after validate targetId.
Created a rule to verify if you have worms before gain fishing skill.

Actual

1 - Fishing was removing worms even without catching the fish.
2- The fishing skill was increased even without having worms on the character.

Expected

1- Worms is only remove if you catch a fish.
2- The fishing skill is increased only if you have more then 0 worms on the character ( as is tibia global, tested ).

Type of change

• [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Fishing and seeing if skills is going up only with worms
fishing and seeing if the worm was removed without catching fish

Test Configuration:

• Server Version: Canary Main
• Client: 13.16
• Operating System: Linux Ubuntu 20.04

Checklist

• [x ] My code follows the style guidelines of this project
• [ x] I have performed a self-review of my own code
• [ x] I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• [ x] I have made corresponding changes to the documentation
• [ x] My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.7% Duplication