improve: move chaining to cpp #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duuh30
reviewed
Jul 16, 2023
dudantas
reviewed
Jul 18, 2023
dudantas
reviewed
Jul 18, 2023
dudantas
approved these changes
Jul 18, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like the title said, moves chaining to cpp. This makes it easier/quicker to implement chaining spells (such as divine dazzle and chivalrous challenge) but also makes it easier to make mobs use chaining attacks (Like this PR does for Harpy and Carnivostrich).
This could also have been a lib in
luabut I chose to move the mechanic to c++ since it's a core part of Tibia these days and not just something that is content specific.Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration