Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sell all loot with pouch #1315

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: sell all loot with pouch #1315

merged 2 commits into from
Aug 2, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Jul 27, 2023

If you make an NPC buy the gold pouch item id, it will then purchase every item from inside the loot pouch for the correct price.

Kapture_2023-07-15_at_00.25.34.1.mp4

@paczielny
Copy link

Could you put an example of the npc? please

@luan
Copy link
Contributor Author

luan commented Jul 27, 2023

Could you put an example of the npc? please

How do I say this without being a jerk... I feel like what I said:

If you make an NPC buy the gold pouch item id, it will then purchase every item from inside the loot pouch for the correct price.

Is plenty of information to go with, if you look at any NPC you can see how it buys items, then you just make one that buys a gold pouch. Please don't ask us to just digest everything for you :)

@luan
Copy link
Contributor Author

luan commented Jul 27, 2023

Ok fine, just because I would love for people to test this.

Add this line too any NPC's npcConfig.shop:

	{ itemName = "all loot in pouch", clientId = ITEM_GOLD_POUCH, sell = 1 },

@paczielny
Copy link

download to test, and when trying to sell the npc responds:
20:27 You have no items in your loot pouch.

@luan
Copy link
Contributor Author

luan commented Aug 2, 2023

download to test, and when trying to sell the npc responds: 20:27 You have no items in your loot pouch.

I'm guessing you didn't have items in your NPC, it only buys items that are already on its list. I added my loot buying npc to the PR: 61da012

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 83d2da8 into main Aug 2, 2023
@dudantas dudantas deleted the luan/sell-from-lootpouch branch August 2, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants