Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete duplicated files from the first dragon quest #1336

Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix: delete duplicated files from the first dragon quest #1336

merged 1 commit into from
Aug 19, 2023

Conversation

RCP91
Copy link
Contributor

@RCP91 RCP91 commented Aug 1, 2023

first_dragon same the_first_dragon

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

first_dragon same the_first_dragon
Copy link
Contributor

@elsongabriel elsongabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aproveita e corrige uns typos:
data-otservbr-global\scripts\creaturescripts\quests\the_first_dragon\death_dragon_essence.lua (linha 12)

APROACHES POR APPROACHES

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
15.4% 15.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dudantas dudantas changed the title Delete Repeated Files fix: delete duplicated files Aug 2, 2023
@dudantas
Copy link
Member

dudantas commented Aug 18, 2023

Could you utilize your pull request to eliminate the duplication of the first dragon in the file "the_first_dragon.lua," located at "data-otservbr-global\monster\quests\the_first_dragon\bosses"

@dudantas dudantas merged commit ec21553 into opentibiabr:main Aug 19, 2023
@dudantas dudantas changed the title fix: delete duplicated files fix: delete duplicated files from the first dragon quest Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants