fix: use item and use with for guests in houses #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
fix-use-item-in-house-by-guest
branch
from
537a1b5 to
a8ac5a7
Compare
dudantas
force-pushed
the
fix-use-item-in-house-by-guest
branch
from
a8ac5a7 to
64020c2
Compare
luan
approved these changes
Aug 4, 2023
luan
approved these changes
Aug 4, 2023
|
has a problem, potions cannot be used in protection zone |
#edit
The pull request only changes the behavior of the houses. |
dudantas
commented
Aug 6, 2023
dudantas
force-pushed
the
fix-use-item-in-house-by-guest
branch
from
62fa13d to
0e1fbaf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
duuh30
approved these changes
Aug 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "ladder" and "dummy" variable in item type to facilitate and improve maintainability of item types that are ladder and dummy.
In addition, some house-related bugs were fixed, such as not being able to use items in the backpack itself (if you are a guest), not being able to use dummy, stairs, and other small problems that interfere with gameplay.
Created a function that exports ladder/dummy IDs to Lua, also facilitating project maintenance, so we don't need hardcoded IDs directly in lua scripts, just define each item in the XML as "ladder" or "dummy", in addition to server for behaviours like of houses...