Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: extract duplicate calls into variables #1349

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

luanluciano93
Copy link
Contributor

Mesmo que seja imperceptível, isso pode ser melhor escrito desta maneira.

Creio que os títulos são alcançados nos devidos pontos e não acima deles.

Não tenho certeza se o "title" e o "bonus" precisam ser trocados mesmo que seja "" e 0, respectivamente.

@luan luan changed the title Removendo a múltiplas chamadas de função em loyalty_lib improve: extract duplicate calls into variables Aug 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dudantas dudantas merged commit ff8ce32 into opentibiabr:main Aug 7, 2023
@luanluciano93 luanluciano93 deleted the luanluciano93-loyalty branch September 7, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants