fix: show correct fluid names #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
reviewed
Aug 7, 2023
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved to loading appearances.dat we started ignoring the fluids from items.xml. This was done as a protection when people add new items to items.xml that aren't in appearances.dat, but it incorrectly filtered out fluids.
Also: it was previously possible to sell the vial/bucket/whatever on the market because fluid id was some dirty memory space, that is now no longer possible since you can no longer obtain the broken fluid.