feat: add event callback to "on rotate item" and simplify callbacks #1370
+240
−815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirkaanks
approved these changes
Aug 8, 2023
luanluciano93
approved these changes
Aug 8, 2023
dudantas
changed the title
luan
reviewed
Aug 8, 2023
dudantas
force-pushed
the
feat-on-rotate-item-event-callback
branch
from
a58f0f1 to
e51ca7b
Compare
luan
approved these changes
Aug 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1350
Removed some callback repetitions.
Removed repetitions of callbacks in revscriptsys.lua, now the valid callbacks will come directly from cpp in a table, which will be compared and if it is invalid it will be informed in the distro about it.
Some other minor callback related detail improvements.