Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: std::map to btree_map and std::set to btree_set #1376

Merged
merged 2 commits into from
Aug 10, 2023
Merged

improve: std::map to btree_map and std::set to btree_set #1376

merged 2 commits into from
Aug 10, 2023

Conversation

mehah
Copy link
Contributor

@mehah mehah commented Aug 10, 2023

using the set and map containers of parallel hashmap, as they are faster and consume less memory.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

@dudantas dudantas merged commit 6807c83 into opentibiabr:main Aug 10, 2023
@mehah mehah deleted the phmap_btree branch August 13, 2023 02:15
dudantas added a commit that referenced this pull request Aug 22, 2023
We found potential issues that could occur (from crashing to things not working) because of this change. So we decided to roll back and change little by little (where and when needed).

Revert from: #1376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants