Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add podium of tenacity and fix bugs related to podium #1379

Conversation

dudantas
Copy link
Member

Description

Added:
• Parse to items.xml for read "transformOnUse".It should be used for simple transformations, which don't need complex scripting. • Podium of tenacity feature
• "/addbosskill" talkaction for add amount of kills (bosstiary) to certain player (or itself).

image

Fixed:
• Rotate from podium of vigor and renown.
• Size of "boss race id" to uint16_t and now it use the "raceid" from bestiary (it's the same).

I made some other small tweaks and improvements.

Type of change

  • New feature (non-breaking change which adds functionality)

Added:
• Parse to items.xml for read "transformOnUse".It should be used for simple transformations, which don't need complex scripting.
• Podium of tenacity feature
• "/addbosskill" talkaction for add amount of kills (bosstiary) to certain player (or itself).

Fixed:
• Rotate from podium of vigor and renown.
• Size of "boss race id" to uint16_t and now it use the "raceid" from bestiary (it's the same).

I made some other small tweaks and improvements.
@dudantas dudantas force-pushed the feat-podium-of-tenacity-and-other-podium-fixes branch from a048ba1 to c98c0dd Compare August 11, 2023 01:38
@dudantas dudantas force-pushed the feat-podium-of-tenacity-and-other-podium-fixes branch from 94a5dcf to 0e8c3f8 Compare August 11, 2023 17:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit ea35a0e into opentibiabr:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants