fix: wheel of destiny damage buff leaking into immunity #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 15, 2023
lgrossi
pushed a commit
to dudantas/canary
that referenced
this pull request
Aug 18, 2023
…1381) Prior to this, monsters that are not supposed to that damage, such as the Giant Beaver and Magic Towers still take damage from the boost. This is kind of a hacky change, but we rely on the damage being zero going into the boost to filter it out. It will work in all cases, and the worst thing it's doing is not giving the boost when you completely miss a hit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, monsters that are not supposed to that damage, such as the Giant Beaver and Magic Towers still take damage from the boost:
This is kind of a hacky change, but we rely on the damage being zero going into the boost to filter it out. It will work in all cases, and the worst thing it's doing is not giving the boost when you completely miss a hit.